[libvirt] [dbus PATCH 03/15] Implement GetBlockIoTune method for Domain Interface

Ján Tomko jtomko at redhat.com
Wed Apr 25 11:43:21 UTC 2018


On Wed, Apr 25, 2018 at 12:20:18PM +0200, Katerina Koukiou wrote:
>Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
>---
> data/org.libvirt.Domain.xml |  7 +++++++
> src/domain.c                | 40 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 47 insertions(+)
>
>diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
>index 2d8f6fe..6f80cc7 100644
>--- a/data/org.libvirt.Domain.xml
>+++ b/data/org.libvirt.Domain.xml
>@@ -171,6 +171,13 @@
>       <arg name="flags" type="u" direction="in"/>
>       <arg name="BlkioParameters" type="a{sv}" direction="out"/>
>     </method>
>+    <method name="GetBlockIoTune">

s/Io/IO/

it's capitalized in every API implemented so far

>+      <annotation name="org.gtk.GDBus.DocString"
>+        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetBlockIoTune"/>
>+      <arg name="disk" type="s" direction="in"/>
>+      <arg name="flags" type="u" direction="in"/>
>+      <arg name="blockIoTune" type="a{sv}" direction="out"/>

here too

>+    </method>
>     <method name="GetControlInfo">
>       <annotation name="org.gtk.GDBus.DocString"
>         value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetControlInfo"/>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180425/fc412b90/attachment-0001.sig>


More information about the libvir-list mailing list