[libvirt] [dbus PATCH 03/15] Implement GetBlockIoTune method for Domain Interface

[Ján Tomko]

On Wed, Apr 25, 2018 at 02:58:12PM +0200, Katerina Koukiou wrote:
>On Wed, 2018-04-25 at 13:43 +0200, Ján Tomko wrote:
>> On Wed, Apr 25, 2018 at 12:20:18PM +0200, Katerina Koukiou wrote:
>> > Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
>> > ---
>> > data/org.libvirt.Domain.xml |  7 +++++++
>> > src/domain.c                | 40
>> > ++++++++++++++++++++++++++++++++++++++++
>> > 2 files changed, 47 insertions(+)
>> >
>> > diff --git a/data/org.libvirt.Domain.xml
>> > b/data/org.libvirt.Domain.xml
>> > index 2d8f6fe..6f80cc7 100644
>> > --- a/data/org.libvirt.Domain.xml
>> > +++ b/data/org.libvirt.Domain.xml
>> > @@ -171,6 +171,13 @@
>> >       <arg name="flags" type="u" direction="in"/>
>> >       <arg name="BlkioParameters" type="a{sv}" direction="out"/>
>> >     </method>
>> > +    <method name="GetBlockIoTune">
>>
>> s/Io/IO/
>>
>> it's capitalized in every API implemented so far'
>
>I follow the convention that I keep the method name as the original API
>name, apart from when there is the `Flags` suffix. Would you mind if we
>keep using this approach?
>

Yes, I would mind.

But the explanation makes sense.
With or without the name change:

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180425/cfb3f577/attachment-0001.sig>