[libvirt] [PATCH 18/30] storage/: Remove spaces after casts

Ján Tomko jtomko at redhat.com
Thu Apr 26 07:51:49 UTC 2018


On Wed, Apr 25, 2018 at 03:24:55PM +0200, Martin Kletzander wrote:
>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>---
> src/storage/storage_backend_fs.c       |  2 +-
> src/storage/storage_backend_gluster.c  |  6 ++--
> src/storage/storage_backend_logical.c  |  2 +-
> src/storage/storage_backend_vstorage.c |  6 ++--
> src/storage/storage_driver.c           |  6 ++--
> src/storage/storage_util.c             | 44 +++++++++++++-------------
> 6 files changed, 33 insertions(+), 33 deletions(-)
>
>diff --git a/src/storage/storage_backend_vstorage.c b/src/storage/storage_backend_vstorage.c
>index 076617aeb634..fcaebf29e7c6 100644
>--- a/src/storage/storage_backend_vstorage.c
>+++ b/src/storage/storage_backend_vstorage.c
>@@ -45,11 +45,11 @@ virStorageBackendVzPoolStart(virStoragePoolObjPtr pool)
>     char *mode = NULL;
>
>     /* Check the permissions */
>-    if (def->target.perms.mode == (mode_t) - 1)

Same here.

>+    if (def->target.perms.mode == (mode_t)- 1)
>         def->target.perms.mode = VIR_STORAGE_DEFAULT_POOL_PERM_MODE;
>-    if (def->target.perms.uid == (uid_t) -1)
>+    if (def->target.perms.uid == (uid_t)-1)
>         def->target.perms.uid = geteuid();
>-    if (def->target.perms.gid == (gid_t) -1)
>+    if (def->target.perms.gid == (gid_t)-1)
>         def->target.perms.gid = getegid();
>
>     /* Convert ids to names because vstorage uses names */

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180426/3305964d/attachment-0001.sig>


More information about the libvir-list mailing list