[libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

[Michal Privoznik]

On 04/26/2018 09:34 PM, Peter Krempa wrote:
> On Thu, Apr 26, 2018 at 18:00:15 +0200, Michal Privoznik wrote:
>> On 04/26/2018 02:56 PM, Ján Tomko wrote:
>>> On Fri, Apr 20, 2018 at 11:09:31AM +0200, Michal Privoznik wrote:
> 
> [...]
> 
>> So what was the showstopper for this patch? I wanted to get this in
>> upcoming release (and freeze is tomorrow). And having v5 for something
>> trivial like this sounds unbelievable.
> 
> I don't think that this tone is warranted.

I'm genuinely asking, because it is not obvious to me what was the major
problem.

> Even if you would get an
> ACK/rb for this patch you would not make it into the release. The review
> was sent 24 seconds _after_ the release-candidate was tagged:

Shoot. 24 seconds.

> While I don't want to question your supernatural patch-fixing skill,
> fixing the typos and the mailing list delay would easily consume the 15
> minutes until the freeze was announced. And it could be even less than
> that as the tag was probably pushed prior to sending the anouncement.
> 

That's why I usually paste diff what needs to be squashed in and say
ACK. It also helps encouraging contributors IMO. Unless it is something
conceptual which renders patch needless.

Michal