[libvirt] [PATCH 2/2] qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString

Daniel P. Berrangé berrange at redhat.com
Fri Apr 27 13:26:40 UTC 2018


On Fri, Apr 27, 2018 at 03:16:46PM +0200, Peter Krempa wrote:
> The code setting TLS parameters verifies that TLS is supported by
> looking at the dump of parameters which will be reset after migration,
> but sets the parameters in the list of new parameters. As
> qemuMigrationParamsSetString did not set the 'set' property, the TLS
> parameters would not be used.
> 
> This is a regression after the series refactoring migration parameters
> and it resulted into TLS not being used even when requested.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/qemu/qemu_migration_params.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list