[libvirt] [PATCH 2/2] qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString

[Ján Tomko]

On Fri, Apr 27, 2018 at 03:16:46PM +0200, Peter Krempa wrote:
>The code setting TLS parameters verifies that TLS is supported by
>looking at the dump of parameters which will be reset after migration,
>but sets the parameters in the list of new parameters. As
>qemuMigrationParamsSetString did not set the 'set' property, the TLS
>parameters would not be used.
>
>This is a regression after the series refactoring migration parameters
>and it resulted into TLS not being used even when requested.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_migration_params.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
>index c5d7ab9016..578cd6671f 100644
>--- a/src/qemu/qemu_migration_params.c
>+++ b/src/qemu/qemu_migration_params.c
>@@ -777,6 +777,15 @@ qemuMigrationParamsApply(virQEMUDriverPtr driver,
> }
>
>
>+/**
>+ * qemuMigrationParamsSetString:
>+ * @migrParams: migration parameter object

s/migrP/migP/

>+ * @param: parameter to set
>+ * @value: new value
>+ *
>+ * Enables and sets the migration parameter @param in @migrParams. Returns 0 on

Here too.

Jano

>+ * success and -1 on error. Libvirt error is reported.
>+ */
> static int
> qemuMigrationParamsSetString(qemuMigrationParamsPtr migParams,
>                              qemuMigrationParam param,
>@@ -788,6 +797,8 @@ qemuMigrationParamsSetString(qemuMigrationParamsPtr migParams,
>     if (VIR_STRDUP(migParams->params[param].value.s, value) < 0)
>         return -1;
>
>+    migParams->params[param].set = true;
>+
>     return 0;
> }
>
>-- 
>2.16.2
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180427/4f437d07/attachment-0001.sig>