[libvirt] [PATCH v2 1/4] Revert "util: virlog: Introduce wildcard to log filters"

Daniel P. Berrangé berrange at redhat.com
Fri Apr 27 13:50:09 UTC 2018


On Fri, Apr 27, 2018 at 09:38:06AM -0400, John Ferlan wrote:
> 
> 
> On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote:
> > This reverts commit 8daa593b0741452a78daea76075254ae7d3c6ab6.
> > 
> > There are two undesirable aspects to the impl
> > 
> >   - Only a bare wildcard is permitted
> >   - The wildcard match is not performed in the order listed
> > ---
> >  src/remote/libvirtd.conf |  4 +---
> >  src/util/virlog.c        | 44 +-------------------------------------------
> >  src/util/virlog.h        |  1 -
> >  3 files changed, 2 insertions(+), 47 deletions(-)
> > 
> 
> So that it's not forgotten 0-) before 4.3.0...
> 
> Reviewed-by: John Ferlan <jferlan at redhat.com>
> 
> Safe too as long as you also revert:
> 
> 209d4d6f42a01829c68ef54b042a0c53ef0b22d3
> 
> to remove the description from news.xml
> 
> I believe the rest can wait for 4.4.0, right?

Yeah, that's fine with me.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list