[libvirt] [PATCH 02/14] nwfilter: remove methods that are trivial wrappers for virHash APIs

Jiri Denemark jdenemar at redhat.com
Mon Apr 30 13:16:08 UTC 2018


On Fri, Apr 27, 2018 at 16:25:01 +0100, Daniel P. Berrangé wrote:
> This removes the virNWFilterHashTableFree, virNWFilterHashTablePut
> and virNWFilterHashTableRemove methods, in favour of just calling
> the virHash APIs directly.
> 
> The virNWFilterHashTablePut method was unreasonably complex because
> the virHashUpdateEntry already knows how to create the entry if it
> does not currently exist.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/conf/domain_conf.c                 |  6 ++--
>  src/conf/nwfilter_conf.c               |  2 +-
>  src/conf/nwfilter_ipaddrmap.c          |  7 ++--
>  src/conf/nwfilter_params.c             | 62 ++--------------------------------
>  src/conf/nwfilter_params.h             |  6 ----
>  src/libvirt_private.syms               |  3 --
>  src/nwfilter/nwfilter_dhcpsnoop.c      |  4 +--
>  src/nwfilter/nwfilter_gentech_driver.c | 18 +++++-----
>  src/nwfilter/nwfilter_learnipaddr.c    |  4 +--
>  tests/nwfilterxml2firewalltest.c       | 10 +++---
>  10 files changed, 28 insertions(+), 94 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar at redhat.com>




More information about the libvir-list mailing list