[libvirt] [PATCH] util: virrandom: make virRandomBits endian-safe

Bjoern Walk bwalk at linux.ibm.com
Thu Aug 2 08:17:32 UTC 2018


Pino Toscano <ptoscano at redhat.com> [2018-08-02, 10:02AM +0200]:
> I do not think this patch is correct: we are dealing with random bytes,
> so there is no "endianness" for them.

Well, it's not incorrect either, isn't it? I agree that endianness
doesn't matter for random data, but in the same time, it doesn't hurt to
have the same random data generated on big- and little-endian machines.
And it gives an easy and future-proof fix for the mocked tests.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 902 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180802/5b2ee63a/attachment-0001.sig>


More information about the libvir-list mailing list