[libvirt] [PATCH v1 25/32] util: numa: use VIR_AUTOPTR for aggregate types
Erik Skultety
eskultet at redhat.com
Mon Aug 6 14:36:00 UTC 2018
On Sat, Jul 28, 2018 at 11:31:40PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of our cleanup sections.
>
> Signed-off-by: Sukrit Bhatnagar <skrtbhtngr at gmail.com>
> ---
> src/util/virnuma.c | 28 +++++++++-------------------
> 1 file changed, 9 insertions(+), 19 deletions(-)
>
> diff --git a/src/util/virnuma.c b/src/util/virnuma.c
> index 841c7cb..fde46ec 100644
> --- a/src/util/virnuma.c
> +++ b/src/util/virnuma.c
> @@ -57,7 +57,7 @@ char *
> virNumaGetAutoPlacementAdvice(unsigned short vcpus,
> unsigned long long balloon)
> {
> - virCommandPtr cmd = NULL;
> + VIR_AUTOPTR(virCommand) cmd = NULL;
I'll fix the ordering as I mentioned earlier and merge.
Reviewed-by: Erik Skultety <eskultet at redhat.com>
More information about the libvir-list
mailing list