[libvirt] [PATCH v1 30/32] util: process: use VIR_AUTOPTR for aggregate types
Erik Skultety
eskultet at redhat.com
Tue Aug 7 06:43:56 UTC 2018
On Sat, Jul 28, 2018 at 11:31:45PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of our cleanup sections.
>
> Signed-off-by: Sukrit Bhatnagar <skrtbhtngr at gmail.com>
> ---
> src/util/virprocess.c | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/src/util/virprocess.c b/src/util/virprocess.c
> index 1dd14de..b51d899 100644
> --- a/src/util/virprocess.c
> +++ b/src/util/virprocess.c
> @@ -982,16 +982,15 @@ int virProcessGetStartTime(pid_t pid,
> {
> VIR_AUTOFREE(char *) filename = NULL;
> VIR_AUTOFREE(char *) buf = NULL;
> + VIR_AUTOPTR(virString) tokens = NULL;
I'll take care of moving this.
Reviewed-by: Erik Skultety <eskultet at redhat.com>
More information about the libvir-list
mailing list