[libvirt] [PATCH 1/2] util: virnetdevopenvswitch: Drop an unused variable @ovs_timeout

Ján Tomko jtomko at redhat.com
Wed Aug 8 07:14:01 UTC 2018


On Wed, Aug 08, 2018 at 08:23:41AM +0200, Erik Skultety wrote:
>Technically, it was never used ever since commit @f4d06ca8fd9 introduced
>it, but the fact that we called VIR_FREE on it was enough for Clang to
>never complain about it.
>
>Signed-off-by: Erik Skultety <eskultet at redhat.com>
>---
>
>CC'ing Boris, as he allowed specifying timeouts for openvswitch calls, however,
>this particular one hasn't been in use ever.
>

Looks like an oversight by Michal when he made adjustments before
pushing the series:
https://www.redhat.com/archives/libvir-list/2017-February/msg00407.html

The timeout addition is handled by virNetDevOpenvswitchAddTimeout,
this is harmless.

> src/util/virnetdevopenvswitch.c | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180808/a4051d7e/attachment-0001.sig>


More information about the libvir-list mailing list