[libvirt] [PATCH 2/2] Fix the build on non-linux platforms after VIR_AUTOPTR related changes

Ján Tomko jtomko at redhat.com
Wed Aug 8 07:16:20 UTC 2018


On Wed, Aug 08, 2018 at 08:23:42AM +0200, Erik Skultety wrote:
>Commits 7b706f33ac and 4acb7887e4 introduced some compound type *Free
>wrappers in order to use them with VIR_DEFINE_AUTOPTR_FUNC. However,
>since those were not used in the code right away, Clang complained about
>unused functions (static ones that are defined by the macro above).
>This patch puts the defined functions in use.
>

If you keep the series bisectable even with clang with warnings turned
on, you can GET a cookie!

>Signed-off-by: Erik Skultety <eskultet at redhat.com>
>---
> src/util/virnetdev.c  | 3 +--
> src/util/virnetlink.c | 6 ++----
> 2 files changed, 3 insertions(+), 6 deletions(-)
>

This fixes the build for me with CLang 5.0.1

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180808/6194435d/attachment-0001.sig>


More information about the libvir-list mailing list