[libvirt] [PATCH 4/6] tests: qemuxml2argv: Add 2 floppy drive tests for q35 with 2.9 and 2.11 machine

Ján Tomko jtomko at redhat.com
Thu Aug 9 13:58:24 UTC 2018


On Thu, Aug 09, 2018 at 02:48:57PM +0200, Peter Krempa wrote:
>The floppy drive command line is different on the q35 machine. Make sure
>to test that both drives are supported and also multiple machine
>versions as we generate the commandline differently.
>
>Note that both output files show wrong command line which will be fixed
>subsequently.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> .../disk-floppy-q35-2_11.x86_64-latest.args        | 37 +++++++++++++++++++++
> tests/qemuxml2argvdata/disk-floppy-q35-2_11.xml    | 38 ++++++++++++++++++++++
> .../disk-floppy-q35-2_9.x86_64-latest.args         | 36 ++++++++++++++++++++
> tests/qemuxml2argvdata/disk-floppy-q35-2_9.xml     | 38 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c                           |  2 ++
> 5 files changed, 151 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_11.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_11.xml
> create mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_9.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_9.xml
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180809/2becee9f/attachment-0001.sig>


More information about the libvir-list mailing list