[libvirt] [dbus PATCH 1/4] tests: Drop pytest.mark.usefixtures from test_nodedev

Ján Tomko jtomko at redhat.com
Mon Aug 13 12:11:24 UTC 2018


On Fri, Jul 27, 2018 at 02:37:38PM +0200, Andrea Bolognani wrote:
>We're already using node_device_create explicitly for all
>test cases in order to retrieve the result of the fixture,
>so using pytest.mark.usefixtures as well is pointless.
>
>Additionally, we're soon going to add some test cases
>where we need the fixture *not* to run automatically.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> tests/test_nodedev.py | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/tests/test_nodedev.py b/tests/test_nodedev.py
>index 22c8d60..082cf0b 100755
>--- a/tests/test_nodedev.py
>+++ b/tests/test_nodedev.py
>@@ -5,7 +5,6 @@ import libvirttest
> import pytest
>
>
>- at pytest.mark.usefixtures("node_device_create")
> class TestNodeDevice(libvirttest.BaseTestClass):
>     """ Tests for methods and properties of the NodeDevice interface
>     """

This patch broke syntax-check:
./tests/test_nodedev.py:5:1: F401 'pytest' imported but unused
import pytest
^

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180813/46b4aee7/attachment-0001.sig>


More information about the libvir-list mailing list