[libvirt] [PATCH v2 0/8] storage: Resolve some locking issues

Michal Privoznik mprivozn at redhat.com
Mon Aug 20 12:09:43 UTC 2018


Technically, this is a v2 of:

https://www.redhat.com/archives/libvir-list/2018-August/msg00624.html

but majority of the patches are new. The review of the patch from above
made me look into storage pool locking more and I have found some
issues.

For best view of the patches (esp. 4/8 use --histogram option).

Michal Prívozník (8):
  storage_backend_rbd: Drop ATTRIBUTE_UNUSED for arguments that are used
  virstorageobj: Move virStoragePoolObjIsDuplicate up
  virstorageobj: Check for duplicates from virStoragePoolObjAssignDef
  virstorageobj: Move virStoragePoolObjSourceFindDuplicate and friends
    up
  virStoragePoolObjSourceFindDuplicate: Drop @conn argument
  virstorageobj: Check for source duplicates from
    virStoragePoolObjAssignDef
  storage_driver: Mark volume as 'in use' for some operations
  storage_driver: Release pool object lock for some long running jobs

 src/conf/virstorageobj.c                   | 937 +++++++++++++++--------------
 src/conf/virstorageobj.h                   |  13 +-
 src/libvirt_private.syms                   |   2 -
 src/storage/storage_backend_iscsi_direct.c |   6 +-
 src/storage/storage_backend_rbd.c          |  12 +-
 src/storage/storage_driver.c               |  56 +-
 src/test/test_driver.c                     |  12 +-
 7 files changed, 529 insertions(+), 509 deletions(-)

-- 
2.16.4




More information about the libvir-list mailing list