[libvirt] [PATCH] qemu: Introduce 16550A serial console model

[Ján Tomko]

On Mon, Aug 27, 2018 at 02:10:18PM +0200, Andrea Bolognani wrote:
>None of the existing models is suitable for use with
>RISC-V virt guests, and we don't want information about
>the serial console to be missing from the XML.
>
>The name is based on comments in qemu/hw/riscv/virt.c:
>
>  RISC-V machine with 16550a UART and VirtIO MMIO
>
>and in qemu/hw/char/serial.c:
>
>  QEMU 16550A UART emulation
>
>along with the output of dmesg in the guest:
>
>  Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
>  10000000.uart: ttyS0 at MMIO 0x10000000 (irq = 13,
>    base_baud= 230400) is a 16550A
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
>CC'ing Rich mostly so that he can double-check the name
>choice is sensible.
>
> docs/formatdomain.html.in                 | 12 +++++-----
> docs/schemas/domaincommon.rng             |  1 +
> src/conf/domain_conf.c                    |  1 +
> src/conf/domain_conf.h                    |  1 +
> src/qemu/qemu_command.c                   | 12 ++++++++++
> src/qemu/qemu_domain.c                    | 27 ++++++++++++++++-------
> tests/qemuxml2xmloutdata/riscv64-virt.xml |  4 +++-
> 7 files changed, 44 insertions(+), 14 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

We should consider auto-adding the device to domain XML, if it's always
present in the machine type.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180828/04e4b401/attachment-0001.sig>