[libvirt] [PATCH] storage: Fix mention of disk pool default

[Eric Blake]

On 08/30/2018 08:41 AM, John Ferlan wrote:

> 
> "dos" is the expected <format type='%s'...> value; however, "msdos" is
> the value used by "parted mklabel --script msdos" (see
> virStorageBackendDiskBuildPool)
> 
> So that line in the storage page for the Disk pool description isn't
> entirely wrong, but it is somewhat misleading. I would say it's more
> that the pool format is dos which generates an on disk partition format
> of msdos (or some sort of wordsmithing).

How about squashing this in?  That way, you can still grep for 'msdos'.

diff --git i/docs/storage.html.in w/docs/storage.html.in
index 6ec623831c..9adcc2a87f 100644
--- i/docs/storage.html.in
+++ w/docs/storage.html.in
@@ -357,8 +357,10 @@
        </li>
      </ul>
      <p>
-      The <code>dos</code> or <code>gpt</code> formats are recommended for
-      best portability - the latter is needed for disks larger than 2TB.
+      The formats <code>dos</code> ("msdos" in parted terminology,
+      good for BIOS systems) or <code>gpt</code> (good for UEFI
+      systems) are recommended for best portability - the latter is
+      needed for disks larger than 2TB.
      </p>

      <h3>Valid volume format types</h3>


> 
> In any case, I'm OK with changing to just "dos", but I won't complain if
> the partition format verbiage is added.
> 
> Reviewed-by: John Ferlan <jferlan at redhat.com>
> SFF,
> 
> John
> 
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org