[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/5] Unify check for auth and auth->cb



Hi guys,

in some drivers, auth and auth->cb are checked in connectOpen function, while in xenapi,
only auth is checked, which that could lead to a problem if cb if invalid. In
phyp, auth and auth->cb are checked twice, in getUser and getPassword.

So, this patchset adds the check for auth and auth->cb inside
virAuthGetUsername and virAuthGetPassword, making it safer for all drivers that
rely in auth callbacks.

Marcos Paulo de Souza (5):
  virauth.c: Check for valid auth callback
  esx: Drop check for auth and auth->cb
  hyperv: Drop check for auth and auth->cb
  phyp: Drop check for auth and auth->cb
  xenapi: Drop check for auth

 src/esx/esx_driver.c       |  7 -------
 src/hyperv/hyperv_driver.c |  7 -------
 src/phyp/phyp_driver.c     | 11 -----------
 src/util/virauth.c         | 12 ++++++++++++
 src/xenapi/xenapi_driver.c |  6 ------
 5 files changed, 12 insertions(+), 31 deletions(-)

-- 
2.17.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]