[libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes
Daniel P. Berrangé
berrange at redhat.com
Tue Aug 7 14:28:52 UTC 2018
On Tue, Aug 07, 2018 at 03:54:06PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-08-07 at 13:22 +0100, Daniel P. Berrangé wrote:
> [...]
> > + * Our preferred pmachine might have been compiled out of
>
> s/pmachine/machine/
>
> > + * QEMU at build time though, so we still fallback to honouring
> > + * QEMU's reported default in that case
> > + */
> > + if (preferredIdx == -1)
> > + preferredIdx = defIdx;
> > + if (preferredIdx != -1)
> > + virQEMUCapsSetDefaultMachine(qemuCaps, preferredIdx);
>
> This is certainly an improvement compared to the current situation,
> so
>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
> I wonder if we shouldn't just drop the default machine type handling
> altogether at this point, though.
That's impossible as it violates the back compatibility guarantee
and will certainly break applications
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list