[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] spec: Use %make_install

On Tue, Jul 31, 2018 at 11:42:40AM -0400, Cole Robinson wrote:
It's on RHEL7, saves a bit of typing, and lets us drop the comment

I tried it looks like it works.

Reviewed-by: Martin Kletzander <mkletzan redhat com>

Signed-off-by: Cole Robinson <crobinso redhat com>
There's also a %make_build macro which handles smp_mflags, but it uses
make -O which makes build output noisier at least

libvirt.spec.in | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 4113579e47..01f4e07b1c 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1255,10 +1255,7 @@ rm -fr %{buildroot}

export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/%{name}.spec)

-# Avoid using makeinstall macro as it changes prefixes rather than setting
-# DESTDIR. Newer make_install macro would be better but it's not available
-# on RHEL 5, thus we need to expand it here.
-make %{?_smp_mflags} install DESTDIR=%{?buildroot} SYSTEMD_UNIT_DIR=%{_unitdir} V=1
+%make_install %{?_smp_mflags} SYSTEMD_UNIT_DIR=%{_unitdir} V=1

make %{?_smp_mflags} -C examples distclean V=1


libvir-list mailing list
libvir-list redhat com

Attachment: signature.asc
Description: Digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]