[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 11/11] util: qemu: use VIR_AUTOPTR for aggregate types



My bad. You can ignore this patch.
On Thu, 9 Aug 2018 at 18:18, Erik Skultety <eskultet redhat com> wrote:
>
> On Thu, Aug 09, 2018 at 09:42:19AM +0530, Sukrit Bhatnagar wrote:
> > By making use of GNU C's cleanup attribute handled by the
> > VIR_AUTOPTR macro for declaring aggregate pointer variables,
> > majority of the calls to *Free functions can be dropped, which
> > in turn leads to getting rid of most of our cleanup sections.
> >
> > Signed-off-by: Sukrit Bhatnagar <skrtbhtngr gmail com>
> > ---
> >  src/util/virqemu.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/util/virqemu.c b/src/util/virqemu.c
> > index bc78853..1cd2b93 100644
> > --- a/src/util/virqemu.c
> > +++ b/src/util/virqemu.c
> > @@ -281,6 +281,7 @@ virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr srcdef)
> >   cleanup:
> >      virBufferFreeAndReset(&buf);
> >      return ret;
> > +
>
> I'm sure you wanted to add some more into the commit, right? :)
>
> Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]