[libvirt] [PATCH v2 00/20] Fix and improve hugepage code
Michal Privoznik
mprivozn at redhat.com
Fri Aug 10 07:26:26 UTC 2018
On 08/09/2018 02:38 PM, Pavel Hrdina wrote:
> changes in v2:
> - renamed existing test cases to sensible names
> - split of some existing test cases
> - fixed uncovered issue with memory discard
>
> v1: https://www.redhat.com/archives/libvir-list/2018-July/msg00667.html
>
> Pavel Hrdina (20):
> tests: rename hugepages to hugepages-default
> tests: extract hugepages-numa-default-dimm out of hugepages-numa
> tests: rename hugepages-numa into hugepages-numa-default
> tests: remove unnecessary XML elements from hugepages-numa-default
> tests: extract pages-discard out of hugepages-pages
> tests: rename hugepages-pages into hugepages-numa-nodeset
> tests: rename hugepages-pages2 into hugepages-numa-default-2M
> tests: extract pages-discard-hugepages out of hugepages-pages3
> tests: rename hugepages-pages3 into hugepages-numa-nodeset-part
> tests: rename hugepages-pages4 into hugepages-numa-nodeset-nonexist
> tests: rename hugepages-pages5 into hugepages-default-2M
> tests: rename hugepages-pages6 into hugepages-default-system-size
> tests: rename hugepages-pages7 into pages-dimm-discard
> tests: rename hugepages-pages8 into hugepages-nodeset-nonexist
> tests: introduce hugepages-default-1G-nodeset-2M
> tests: introduce hugepages-nodeset
> conf: Move hugepage XML validation check out of qemu_command
> conf: Move hugepages validation out of XML parser
> conf: Introduce virDomainDefPostParseMemtune
> qemu: ensure that memory 'discard' is used if specified in XML
>
> src/conf/domain_conf.c | 134 +++++++++++++-----
> src/qemu/qemu_command.c | 38 +----
> ...s => hugepages-default-1G-nodeset-2M.args} | 7 +-
> .../hugepages-default-1G-nodeset-2M.xml | 31 ++++
> ...-pages5.args => hugepages-default-2M.args} | 5 +-
> ...es-pages5.xml => hugepages-default-2M.xml} | 13 +-
> .../hugepages-default-system-size.args | 24 ++++
> ....xml => hugepages-default-system-size.xml} | 13 +-
> ...{hugepages.args => hugepages-default.args} | 2 -
> .../{hugepages.xml => hugepages-default.xml} | 5 -
> ...es8.xml => hugepages-nodeset-nonexist.xml} | 13 +-
> tests/qemuxml2argvdata/hugepages-nodeset.args | 26 ++++
> tests/qemuxml2argvdata/hugepages-nodeset.xml | 30 ++++
> ...s2.args => hugepages-numa-default-2M.args} | 5 +-
> ...ges2.xml => hugepages-numa-default-2M.xml} | 8 +-
> ....args => hugepages-numa-default-dimm.args} | 12 +-
> .../hugepages-numa-default-dimm.xml | 45 ++++++
> .../hugepages-numa-default.args | 27 ++++
> .../hugepages-numa-default.xml | 30 ++++
> ...ml => hugepages-numa-nodeset-nonexist.xml} | 17 +--
> ....args => hugepages-numa-nodeset-part.args} | 8 +-
> .../hugepages-numa-nodeset-part.xml | 34 +++++
> ...pages.args => hugepages-numa-nodeset.args} | 17 +--
> ...s-pages.xml => hugepages-numa-nodeset.xml} | 15 +-
> tests/qemuxml2argvdata/hugepages-numa.args | 63 --------
> tests/qemuxml2argvdata/hugepages-numa.xml | 111 ---------------
> .../qemuxml2argvdata/pages-dimm-discard.args | 33 +++++
> ...ages-pages7.xml => pages-dimm-discard.xml} | 18 +--
> .../pages-discard-hugepages.args | 31 ++++
> ...pages3.xml => pages-discard-hugepages.xml} | 16 +--
> tests/qemuxml2argvdata/pages-discard.args | 38 +++++
> tests/qemuxml2argvdata/pages-discard.xml | 36 +++++
> .../seclabel-dynamic-none-relabel.xml | 2 +-
> tests/qemuxml2argvtest.c | 56 ++++----
> .../hugepages-default-2M.xml | 1 +
> .../hugepages-default-system-size.xml | 1 +
> .../{hugepages.xml => hugepages-default.xml} | 6 -
> .../qemuxml2xmloutdata/hugepages-nodeset.xml | 30 ++++
> ...ges2.xml => hugepages-numa-default-2M.xml} | 13 +-
> .../hugepages-numa-default-dimm.xml | 1 +
> .../hugepages-numa-nodeset-part.xml | 36 +++++
> ...s-pages.xml => hugepages-numa-nodeset.xml} | 20 +--
> tests/qemuxml2xmloutdata/hugepages-pages3.xml | 47 ------
> tests/qemuxml2xmloutdata/hugepages-pages4.xml | 1 -
> tests/qemuxml2xmloutdata/hugepages-pages5.xml | 1 -
> tests/qemuxml2xmloutdata/hugepages-pages6.xml | 1 -
> tests/qemuxml2xmloutdata/hugepages-pages7.xml | 1 -
> .../qemuxml2xmloutdata/pages-dimm-discard.xml | 1 +
> .../pages-discard-hugepages.xml | 1 +
> tests/qemuxml2xmloutdata/pages-discard.xml | 1 +
> .../seclabel-dynamic-none-relabel.xml | 2 +-
> tests/qemuxml2xmltest.c | 19 +--
> 52 files changed, 634 insertions(+), 512 deletions(-)
> rename tests/qemuxml2argvdata/{hugepages-pages6.args => hugepages-default-1G-nodeset-2M.args} (72%)
> create mode 100644 tests/qemuxml2argvdata/hugepages-default-1G-nodeset-2M.xml
> rename tests/qemuxml2argvdata/{hugepages-pages5.args => hugepages-default-2M.args} (75%)
> rename tests/qemuxml2argvdata/{hugepages-pages5.xml => hugepages-default-2M.xml} (63%)
> create mode 100644 tests/qemuxml2argvdata/hugepages-default-system-size.args
> rename tests/qemuxml2argvdata/{hugepages-pages6.xml => hugepages-default-system-size.xml} (63%)
> rename tests/qemuxml2argvdata/{hugepages.args => hugepages-default.args} (82%)
> rename tests/qemuxml2argvdata/{hugepages.xml => hugepages-default.xml} (79%)
> rename tests/qemuxml2argvdata/{hugepages-pages8.xml => hugepages-nodeset-nonexist.xml} (64%)
> create mode 100644 tests/qemuxml2argvdata/hugepages-nodeset.args
> create mode 100644 tests/qemuxml2argvdata/hugepages-nodeset.xml
> rename tests/qemuxml2argvdata/{hugepages-pages2.args => hugepages-numa-default-2M.args} (77%)
> rename tests/qemuxml2argvdata/{hugepages-pages2.xml => hugepages-numa-default-2M.xml} (77%)
> rename tests/qemuxml2argvdata/{hugepages-pages7.args => hugepages-numa-default-dimm.args} (66%)
> create mode 100644 tests/qemuxml2argvdata/hugepages-numa-default-dimm.xml
> create mode 100644 tests/qemuxml2argvdata/hugepages-numa-default.args
> create mode 100644 tests/qemuxml2argvdata/hugepages-numa-default.xml
> rename tests/qemuxml2argvdata/{hugepages-pages4.xml => hugepages-numa-nodeset-nonexist.xml} (66%)
> rename tests/qemuxml2argvdata/{hugepages-pages3.args => hugepages-numa-nodeset-part.args} (71%)
> create mode 100644 tests/qemuxml2argvdata/hugepages-numa-nodeset-part.xml
> rename tests/qemuxml2argvdata/{hugepages-pages.args => hugepages-numa-nodeset.args} (62%)
> rename tests/qemuxml2argvdata/{hugepages-pages.xml => hugepages-numa-nodeset.xml} (69%)
> delete mode 100644 tests/qemuxml2argvdata/hugepages-numa.args
> delete mode 100644 tests/qemuxml2argvdata/hugepages-numa.xml
> create mode 100644 tests/qemuxml2argvdata/pages-dimm-discard.args
> rename tests/qemuxml2argvdata/{hugepages-pages7.xml => pages-dimm-discard.xml} (73%)
> create mode 100644 tests/qemuxml2argvdata/pages-discard-hugepages.args
> rename tests/qemuxml2argvdata/{hugepages-pages3.xml => pages-discard-hugepages.xml} (68%)
> create mode 100644 tests/qemuxml2argvdata/pages-discard.args
> create mode 100644 tests/qemuxml2argvdata/pages-discard.xml
> create mode 120000 tests/qemuxml2xmloutdata/hugepages-default-2M.xml
> create mode 120000 tests/qemuxml2xmloutdata/hugepages-default-system-size.xml
> rename tests/qemuxml2xmloutdata/{hugepages.xml => hugepages-default.xml} (82%)
> create mode 100644 tests/qemuxml2xmloutdata/hugepages-nodeset.xml
> rename tests/qemuxml2xmloutdata/{hugepages-pages2.xml => hugepages-numa-default-2M.xml} (67%)
> create mode 120000 tests/qemuxml2xmloutdata/hugepages-numa-default-dimm.xml
> create mode 100644 tests/qemuxml2xmloutdata/hugepages-numa-nodeset-part.xml
> rename tests/qemuxml2xmloutdata/{hugepages-pages.xml => hugepages-numa-nodeset.xml} (62%)
> delete mode 100644 tests/qemuxml2xmloutdata/hugepages-pages3.xml
> delete mode 120000 tests/qemuxml2xmloutdata/hugepages-pages4.xml
> delete mode 120000 tests/qemuxml2xmloutdata/hugepages-pages5.xml
> delete mode 120000 tests/qemuxml2xmloutdata/hugepages-pages6.xml
> delete mode 120000 tests/qemuxml2xmloutdata/hugepages-pages7.xml
> create mode 120000 tests/qemuxml2xmloutdata/pages-dimm-discard.xml
> create mode 120000 tests/qemuxml2xmloutdata/pages-discard-hugepages.xml
> create mode 120000 tests/qemuxml2xmloutdata/pages-discard.xml
>
ACK series.
Michal
More information about the libvir-list
mailing list