[libvirt] [PATCH v2] storage: add wipeVol to iscsi-direct storage backend

Ján Tomko jtomko at redhat.com
Fri Aug 10 13:55:07 UTC 2018


On Fri, Aug 10, 2018 at 03:33:59PM +0200, clem at lse.epita.fr wrote:
>From: Clementine Hayat <clem at lse.epita.fr>
>
>Change set volume capacity to get volume capacity and put the connection
>and helpers in one function to avoid code duplicates.

virStorageBackendISCSIDirectSetConnection addition should be in a
separate commit. And the Set->Get change in another one, leaving just
the wipeVol addition here.

For more on splitting changes into commits, see:
https://www.berrange.com/posts/2012/06/27/thoughts-on-improving-openstack-git-commit-practicehistory/

Jano

>
>Signed-off-by: Clementine Hayat <clem at lse.epita.fr>
>---
>
>Set BLOCK_PER_PACKET to 128. Not sure about this value. Should be
>potentially tuned.
>
> src/storage/storage_backend_iscsi_direct.c | 173 ++++++++++++++++++---
> 1 file changed, 152 insertions(+), 21 deletions(-)
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180810/3eb94e2a/attachment-0001.sig>


More information about the libvir-list mailing list