[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] storage: add wipeVol to iscsi-direct storage backend



On Fri, Aug 10, 2018 at 03:33:59PM +0200, clem lse epita fr wrote:
From: Clementine Hayat <clem lse epita fr>

Change set volume capacity to get volume capacity and put the connection
and helpers in one function to avoid code duplicates.

virStorageBackendISCSIDirectSetConnection addition should be in a
separate commit. And the Set->Get change in another one, leaving just
the wipeVol addition here.

For more on splitting changes into commits, see:
https://www.berrange.com/posts/2012/06/27/thoughts-on-improving-openstack-git-commit-practicehistory/

Jano


Signed-off-by: Clementine Hayat <clem lse epita fr>
---

Set BLOCK_PER_PACKET to 128. Not sure about this value. Should be
potentially tuned.

src/storage/storage_backend_iscsi_direct.c | 173 ++++++++++++++++++---
1 file changed, 152 insertions(+), 21 deletions(-)

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]