[libvirt] [PATCHv2 53/62] qemu: Extract exporting of the header for block stats

[Ján Tomko]

On Mon, Aug 13, 2018 at 06:00:27PM +0200, Peter Krempa wrote:
>Split out the header so that the loop can be refactored later.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 38 ++++++++++++++++++++++++++++----------
> 1 file changed, 28 insertions(+), 10 deletions(-)
>
>diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>index ac9c7faf2e..6ea86c8cbf 100644
>--- a/src/qemu/qemu_driver.c
>+++ b/src/qemu/qemu_driver.c
>@@ -20071,7 +20071,6 @@ qemuDomainGetStatsOneBlock(virQEMUDriverPtr driver,
>                            virDomainObjPtr dom,
>                            virDomainStatsRecordPtr record,
>                            int *maxparams,
>-                           const char *diskdst,
>                            const char *entryname,
>                            virStorageSourcePtr src,
>                            size_t block_idx,
>@@ -20080,14 +20079,6 @@ qemuDomainGetStatsOneBlock(virQEMUDriverPtr driver,
>     qemuBlockStats *entry;
>     int ret = -1;
>
>-    QEMU_ADD_NAME_PARAM(record, maxparams, "block", "name", block_idx, diskdst);
>-
>-    if (virStorageSourceIsLocalStorage(src) && src->path)
>-        QEMU_ADD_NAME_PARAM(record, maxparams, "block", "path",
>-                            block_idx, src->path);
>-    if (src->id)
>-        QEMU_ADD_BLOCK_PARAM_UI(record, maxparams, block_idx, "backingIndex",
>-                                src->id);
>

Actually , this leaves two blank lines here.

>     /* the VM is offline so we have to go and load the stast from the disk by
>      * ourselves */

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180817/35bdd3d4/attachment-0001.sig>