[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/8] virStoragePoolObjSourceFindDuplicate: Drop @conn argument

On 08/20/2018 08:09 AM, Michal Privoznik wrote:
> The @conn argument is needed only to do some source matching in
> case of iSCSI source. Anyway, it's used just for node device
> driver and as such can be replaced with virGetConnectNodeDev().

NB: Since commit 2870419eb enabled opening connections to secondary
drivers at time of use, we no longer have to carry around the storage
driver connection in order to use for the connection.

(or something close to what commit decaeb28 describes)

> At the same time, the @conn struct member is dropped from
> _virStoragePoolObjFindDuplicateData.
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/conf/virstorageobj.c     | 25 +++++++++++--------------
>  src/conf/virstorageobj.h     |  3 +--
>  src/storage/storage_driver.c |  4 ++--
>  3 files changed, 14 insertions(+), 18 deletions(-)

Reviewed-by: John Ferlan <jferlan redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]