[libvirt] [PATCH v5 22/36] qemu_process: Stop locking QMP process monitor immediately

Chris Venteicher cventeic at redhat.com
Mon Dec 3 05:10:16 UTC 2018

Locking the monitor object immediately after call to qemuMonitorOpen
doesn't make sense now that we have expanded the QEMU process code to
cover more than the original capabilities usecase.

Removing the monitor lock makes the qemuProcessQmpConnectMonitor code
consistent with the qemuConnectMonitor code used to establish the
monitor when QEMU process is started for domains.

Signed-off-by: Chris Venteicher <cventeic at redhat.com>
 src/qemu/qemu_process.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 26ba59143d..b491f9f91a 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8331,8 +8331,6 @@ qemuProcessQmpConnectMonitor(qemuProcessQmpPtr proc)
     VIR_STEAL_PTR(proc->mon, mon);
-    virObjectLock(proc->mon);
     /* Exit capabilities negotiation mode and enter QEMU command mode
      * by issuing qmp_capabilities command to QEMU */
     if (qemuMonitorSetCapabilities(proc->mon) < 0) {

More information about the libvir-list mailing list