[libvirt] [PATCH v3 0/2] lxc: Fix a bug related to IPv{4, 6} gateway persistent setting.

John Ferlan jferlan at redhat.com
Tue Dec 11 20:04:07 UTC 2018



On 11/30/18 7:43 AM, Julio Faracco wrote:
> This serie fixes a bug related to IPv{4,6} gateway settings when it is
> defined and used with multiple network definitions. Basically, this data
> is being carried on to the next network settings because the pointer is
> not being cleaned up/initialized properly. The idea behind the fix was
> create a new way to initialize the data without knowing the structure
> attributes. The old way has a high probability to cause new bugs.
> 
> This serie add a new test case to cover this scenario too. It will be so
> important to network index implemented on LXC 3.X.
> 
> v1-v2: Fixing tabs inside the code.
> 
> Julio Faracco (2):
>   lxc: Initializing IPv6 and IPv4 gateway to overwrite old settings.
>   tests: Adding test case to include multiple network definitions.
> 
>  src/lxc/lxc_native.c                          | 27 ++++++-----
>  .../lxcconf2xml-miscnetwork-v3.config         | 23 ++++++++++
>  .../lxcconf2xml-miscnetwork.config            | 23 ++++++++++
>  .../lxcconf2xml-miscnetwork.xml               | 45 +++++++++++++++++++
>  tests/lxcconf2xmltest.c                       |  2 +
>  5 files changed, 106 insertions(+), 14 deletions(-)
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-miscnetwork-v3.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-miscnetwork.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-miscnetwork.xml
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>

(and pushed),

John




More information about the libvir-list mailing list