[libvirt] [PATCH v2 0/2] qemu: fix misc noisy logs for optional storage sources

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Thu Dec 13 11:02:03 UTC 2018


John, I still did not add anything to formatdomain.html.in because when
I gave this a thought it looks odd to add something like "we don't get
stats for missing storage source" - it is obvious because such
getting stats is simply not possible. It you feel there is need to 
add something to the docs then please help me formulate it and we include it in
the patch(es) on pushing.

Nikolay

Diff from v1:
============

- add error logs examples to commit messages
- add notices at INFO level of handling optional disks with
  missing sources in a special way
- comment why handling such cases in a special manner in code
- check for cold_boot flag in qemuProcessPrepareHostStorage

Nikolay Shirokovskiy (2):
  qemu: don't log error for missing optional storage sources on stats
  qemu: don't log error for missing optional storage sources on start

 src/qemu/qemu_domain.c  |  9 +++++++++
 src/qemu/qemu_domain.h  |  3 +++
 src/qemu/qemu_driver.c  | 14 ++++++++++++++
 src/qemu/qemu_process.c | 10 +++++++++-
 4 files changed, 35 insertions(+), 1 deletion(-)

-- 
1.8.3.1




More information about the libvir-list mailing list