[libvirt] [RFC v3 4/4] nvdimm: update news.xml
Luyao Zhong
luyao.zhong at intel.com
Fri Dec 14 08:33:10 UTC 2018
On 2018/12/14 上午10:17, John Ferlan wrote:
>
>
> On 12/12/18 7:53 AM, Luyao Zhong wrote:
>> add more configure options for NVDIMM
>>
>> Signed-off-by: Luyao Zhong <luyao.zhong at intel.com>
>> ---
>> docs/news.xml | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>
> It will be OK to just have one of these assuming each of the options
> gets pushed within the same release.
>
>> diff --git a/docs/news.xml b/docs/news.xml
>> index 5bdbd34..0112c91 100644
>> --- a/docs/news.xml
>> +++ b/docs/news.xml
>> @@ -38,6 +38,15 @@
>> would normally prevent QEMU from accessing such a device.
>> </description>
>> </change>
>> + <change>
>> + <summary>
>> + NVDIMM: support more configurations
>> + </summary>
>> + <description>
>> + Introduce more configuration options supported by QEMU community,
>> + including 'alignsize', 'pmem', 'unarmed' and 'persistence'.
>
> While this is true, look at some of the other entries when attributes
> are added and try to consider what feature is being added here. You
> don't need to be too wordy. Mentioning QEMU community is probably
> unnecessary - speak directly to the feature and a bit of what the
> feature allows.
>
Got it. I will reword in next version.
> John >
Thank you for your comments.
Luyao Zhong
>> + </description>
>> + </change>
>> </section>
>> <section title="Bug fixes">
>> </section>
>>
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
More information about the libvir-list
mailing list