[libvirt] [jenkins-ci PATCH 1/6] guests: Fix FreeBSD symlink kludge

Andrea Bolognani abologna at redhat.com
Mon Dec 17 13:54:23 UTC 2018


The version check was not written in a future-proof manner,
as all versions of FreeBSD after 10 need the kludge.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 guests/playbooks/update/tasks/kludges.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/update/tasks/kludges.yml
index 0ad61a7..f9127ac 100644
--- a/guests/playbooks/update/tasks/kludges.yml
+++ b/guests/playbooks/update/tasks/kludges.yml
@@ -15,8 +15,8 @@
   when:
     - os_name == 'FreeBSD'
 
-# Same as above, except we only need to do it on FreeBSD 11 because
-# FreeBSD 10 shipped (an old version of) readline in the base system
+# Same as above, except we should skip it on FreeBSD 10 because it
+# shipped (an old version of) readline in the base system
 - name: Create compatibility symlinks
   file:
     src: '/usr/local/{{ item }}'
@@ -28,7 +28,7 @@
     - lib/libreadline.so
   when:
     - os_name == 'FreeBSD'
-    - os_version == '11'
+    - os_version != '10'
 
 # FreeBSD compiles bash without defining SSH_SOURCE_BASHRC, which means
 # it won't try to detect when it's spawned by ssh and source ~/.bashrc
-- 
2.19.2




More information about the libvir-list mailing list