[libvirt] [PATCH] virsh: Fix vcpupin command output wrong vcpu pinning info

lhuang lhuang at redhat.com
Thu Dec 20 01:05:00 UTC 2018



On 12/19/2018 05:27 PM, Michal Privoznik wrote:
> On 12/19/18 4:17 AM, Luyao Huang wrote:
>> Commit 3072ded3 changed the waya to format the vcpu pinning info
>> and forget to get cpumap for each vcpu during the loop, that cause
>> vcpupin command will display vcpu 0 info for other vcpus.
>>
>> Signed-off-by: Luyao Huang <lhuang at redhat.com>
>> ---
>>   tools/virsh-domain.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
>> index 4d9f065..24f7852 100644
>> --- a/tools/virsh-domain.c
>> +++ b/tools/virsh-domain.c
>> @@ -6954,7 +6954,8 @@ virshVcpuPinQuery(vshControl *ctl,
>>               if (got_vcpu && i != vcpu)
>>                   continue;
>>   
>> -            if (!(pinInfo = virBitmapDataFormat(cpumap, cpumaplen)))
>> +            if (!(pinInfo = virBitmapDataFormat(VIR_GET_CPUMAP(cpumap, cpumaplen, i),
>> +                                                cpumaplen)))
>>                   goto cleanup;
>>   
>>               if (virAsprintf(&vcpuStr, "%zu", i) < 0)
>>
>
> ACKed and pushed.

Thanks a lot for your quick review !

Luyao

> Michal




More information about the libvir-list mailing list