[libvirt] [designer PATCH 3/6] Add missing break in gvir_designer_domain_add_graphics
Daniel P. Berrangé
berrange at redhat.com
Thu Dec 20 09:41:51 UTC 2018
On Thu, Dec 20, 2018 at 10:23:49AM +0100, Pino Toscano wrote:
> For a GVIR_DESIGNER_DOMAIN_GRAPHICS_DESKTOP graphics type, do not
> fallback on the code handling GVIR_DESIGNER_DOMAIN_GRAPHICS_RDP.
Presumably new GCC warned about this one ?
>
> Signed-off-by: Pino Toscano <ptoscano at redhat.com>
> ---
> libvirt-designer/libvirt-designer-domain.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
>
> diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/libvirt-designer-domain.c
> index adca733..cd9349f 100644
> --- a/libvirt-designer/libvirt-designer-domain.c
> +++ b/libvirt-designer/libvirt-designer-domain.c
> @@ -543,6 +543,8 @@ gvir_designer_domain_add_graphics(GVirDesignerDomain *design,
> graphics = gvir_designer_domain_create_graphics_desktop(design, error);
> if (graphics == NULL)
> return NULL;
> +
> + break;
> }
>
> case GVIR_DESIGNER_DOMAIN_GRAPHICS_RDP: {
> --
> 2.17.2
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list