[libvirt] [PATCH 4/6] port allocator: drop skip flag

[Nikolay Shirokovskiy]

On 29.01.2018 09:09, Michal Privoznik wrote:
> On 12/20/2017 07:35 AM, Nikolay Shirokovskiy wrote:
>> This flag is only used for tests and tests overload socket and bind
>> functions using virportallocatormock.c already in a suitable fashion
>> so we don't need this flag at all.
>> ---
>>  src/bhyve/bhyve_driver.c       |  2 +-
>>  src/libxl/libxl_driver.c       |  5 ++---
>>  src/qemu/qemu_driver.c         |  9 +++------
>>  src/util/virportallocator.c    | 14 ++++----------
>>  src/util/virportallocator.h    |  7 +------
>>  tests/bhyvexml2argvtest.c      |  3 +--
>>  tests/libxlxml2domconfigtest.c |  3 +--
>>  tests/virportallocatortest.c   |  4 ++--
>>  8 files changed, 15 insertions(+), 32 deletions(-)
> 
> 
> It's not that easy. libxlxml2domconfigtest doesn't link with the mock
> therefore if say port 5900 is opened at the time the test runs I get
> different results.
> 

I did't actually check the consequences for libxl and bhyve tests...
Well we can overload bind for these tests too given they already 
overload some functions it won't take much effort.

Nikolay