[libvirt] [PATCH v6 04/14] qemu: Add check for iothread attribute in validate controller

Ján Tomko jtomko at redhat.com
Thu Feb 1 14:57:55 UTC 2018


On Wed, Jan 31, 2018 at 09:57:43PM -0500, John Ferlan wrote:
>Let's make sure that non SCSI virtio-scsi isn't used for any type
>other than a virtio-scsi controller.
>

>This includes removing the check from qemuCheckSCSIControllerIOThreads
>which is a very suble difference because although def->model was used
>in the original comparison and just @model is used in the new comparison,
>the comparison is the same.
>
>This is because qemuDomainSetSCSIControllerModel doesn't change the
>def->model, thus we know that the resultant @model would result in
>either the same as input or if not set, whatever the default model is
>when def->model == -1. In this second case, virtio-scsi is the last
>default chosen.
>

Both of these paragraphs can be deleted now

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180201/56ea6ead/attachment-0001.sig>


More information about the libvir-list mailing list