[libvirt] [PATCH v4] virt-aa-helper: Set the supported features

Peter Krempa pkrempa at redhat.com
Tue Feb 6 14:19:01 UTC 2018


On Tue, Feb 06, 2018 at 14:48:23 +0100, Christian Ehrhardt wrote:
> On Tue, Feb 6, 2018 at 2:42 PM, Peter Krempa <pkrempa at redhat.com> wrote:
> > On Tue, Feb 06, 2018 at 08:08:14 -0500, Shivaprasad G Bhat wrote:
> >> The virt-aa-helper fails to parse the xmls with the memory/cpu
> >> hotplug features or user assigned aliases. Set the features in
> >> xmlopt->config for the parsing to succeed.
> >>
> >> Signed-off-by: Shivaprasad G Bhat <sbhat at linux.vnet.ibm.com>
> >> ---
> >>  src/conf/domain_conf.h        |    2 ++
> >>  src/security/virt-aa-helper.c |    8 +++++++-
> >>  2 files changed, 9 insertions(+), 1 deletion(-)
> >
> > ACK from my side, but I'll wait for a while for the debian/ubuntu guys
> > chiming in.
> 
> I had a review and test on v2.
> This essentially differes by a comment that I also requested - so still ack.
> 
> Tested-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> Reviewed-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>

I've added the tags and pushed the patch.

> 
> P.S. you could say I'm an Ubuntu guy :-)

Definitely :)

Sorry for not addressing you directly but I was too lazy to look up the
previous conversation.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180206/9e45f403/attachment-0001.sig>


More information about the libvir-list mailing list