[libvirt] [PATCH RFCv2 0/4] Add optional pSeries features

[Peter Krempa]

On Tue, Feb 06, 2018 at 17:54:55 +0100, Andrea Bolognani wrote:
> Applies on top of [req].
> 
> RFC because we still don't have a way of probing QEMU to figure
> out whether the relevant toggles are available. Plus, there's no
> documentation yet :)

I wanted to moan about missing docs and sub-par commit messages but
okay. Note that without documentation it's not possible to scrunitize
whether it makes any particular sense to expose a given feature at all.

Since probing is not implemented I don't think it makes sense to
introduce cabapility bits for every single feature since they are
grouped under the same version check.

Even if qemu adds QMP probing of these the capability check will not go
away since it would create a regression in behaviour. This means that
you can remove all the capability bits and group all of them under a
single one since they will only ever be enabled using that version
check.

Also I really don't think that every single feature should have it's own
XML document to test it. You can gradually add them to a single one and
test that all are added.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180206/c1851866/attachment-0001.sig>