[libvirt] [PATCH] conf: Check for NUMA distances in validity check

[Peter Krempa]

On Tue, Feb 06, 2018 at 17:23:47 +0100, Michal Privoznik wrote:
> NUMA distances are part of guest ABI (guests can read it
> directly!) and therefore as such shouldn't change throughout the
> lifetime of domain.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/conf/numa_conf.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
> index c906a53de..7d3f9e661 100644
> --- a/src/conf/numa_conf.c
> +++ b/src/conf/numa_conf.c
> @@ -1073,7 +1073,7 @@ bool
>  virDomainNumaCheckABIStability(virDomainNumaPtr src,
>                                 virDomainNumaPtr tgt)
>  {
> -    size_t i;
> +    size_t i, j;

Please declare j on a separate line.

>      if (virDomainNumaGetNodeCount(src) != virDomainNumaGetNodeCount(tgt)) {
>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> @@ -1102,6 +1102,17 @@ virDomainNumaCheckABIStability(virDomainNumaPtr src,
>                               "match source"), i);
>              return false;
>          }
> +
> +        for (j = 0; j < virDomainNumaGetNodeCount(src); j++) {

Since the matrix of distances is symetrical along the diagonal, do we
really need to check both parts? As in .. how about initializing 'j' to
'i' in this loop?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180206/28c076e0/attachment-0001.sig>