[libvirt] [tck PATCH 5/9] Fix no-arp-spoof test script generation

Laine Stump laine at laine.org
Thu Feb 8 02:04:55 UTC 2018


I'm not sure if or how this ever worked before - what is supposed to
happen is that the shell script in $cmdfile is put into the file
/test.sh on the guest, then /test.sh is executed. But the code was
instead trying to directly execute the text of the entire script as a
single command and write the generated output to /test.sh, then
execute that.

putting echo " ..... " around the whole thing fixed it.
---
 scripts/nwfilter/240-no-arp-spoofing.t | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/nwfilter/240-no-arp-spoofing.t b/scripts/nwfilter/240-no-arp-spoofing.t
index 141fb92..45f790a 100644
--- a/scripts/nwfilter/240-no-arp-spoofing.t
+++ b/scripts/nwfilter/240-no-arp-spoofing.t
@@ -91,11 +91,11 @@ my $ssh = Net::OpenSSH->new($guestip,
                             password => $tck->root_password());
 
 # now generate a arp spoofing packets 
-diag "generate arpspoof";
+diag "generate arpspoof script";
 my $cmdfile = <<EOF;
-/usr/sbin/arpspoof ${spoofid} &
+echo "/usr/sbin/arpspoof ${spoofid} &
 /bin/sleep 10
-kill -15 `/sbin/pidof arpspoof`' > /test.sh
+kill -15 `/sbin/pidof arpspoof`" > /test.sh
 EOF
 
 diag "content of cmdfile:";
-- 
2.13.6




More information about the libvir-list mailing list