[libvirt] [PATCH 0/2] Add {lockd|logd} admin sockets to install

[John Ferlan]

On 02/08/2018 05:16 AM, Daniel P. Berrangé wrote:
> On Tue, Feb 06, 2018 at 01:56:24PM -0500, John Ferlan wrote:
>> Hopefully I covered what's necessary... Essentially a bunch of
>> copying of existing examples...
>>
>> I haven't been able to actually build an RPM locally for a long
>> time, but this does work with make install at least (or at least
>> it worked in the environment I tried it on).
> 
> What sort of problem are you having ?  The CI system is testing our
> RPM builds on Fedora so should work.
> 

Mostly bad and/or lazy (and/or annoyed) user on keyboard...  Never quite
seem to get the "correct packages" installed. Sometimes I get a list of
packages I'm missing from the make rpm command, while other times it's
just a failure and I'm left guessing and debugging. After a while I just
give up hoping that the CI system will do its thing...

Still for these -admin sockets, I see the CI env is happy. I don't
believe a running environment would be as happy as I found with the
-admin socket missing there were errors in virtlogd (at least) restart
or in the first connection from a new libvirtd to virtlogd (I've
forgotten the details already as they've been nwfiltered out ;-)).

Anyway, as for make rpm on one system I had problems w/ "uniconvertor":

/usr/bin/mv: cannot stat '/tmp/magick-14461O4gf8V6BuvWf.svg': No such
file or directory
convert: delegate failed `'uniconvertor' '%i' '%o.svg'; /usr/bin/mv
'%o.svg' '%o'' @ error/delegate.c/InvokeDelegate/1919.

So /me thinks - let's remove it... That didn't work because "convert"
and "ImageMagick" are there... So remove that and get:

convert -rotate 90 libvirt-daemon-arch.fig libvirt-daemon-arch.png
make[3]: convert: Command not found

<sigh>...  Even re-running autogen.sh didn't help. Perhaps there's some
package that I do have that caused autogen.sh to set something that
causes something else to believe I have the right bits.

FWIW: On another system I don't have ImageMagick or uniconvertor and
that actually builds the rpm after installing a few things along the
way. So WTF knows - it's all black magic and hokum to me.

John