[libvirt] [tck PATCH v2 1/5] parameterize filterref in generic_domain

[Daniel P. Berrangé]

On Thu, Feb 08, 2018 at 02:19:35PM -0500, Laine Stump wrote:
> The default filterref is still clean-traffic, but we can now set it to
> "no-broadcast-mac" for the test by that same name.
> 
> This corrects a problem with the no-mac-broadcast test, which was
> checking to see that packets with a destination MAC address of
> ff:ff:ff:ff:ff:ff weren't allowed, but was neglecting to add the
> "no-mac-broadcast" nwfilter to the domain (the test was erroneously
> succeeding because it was checking for a different type of packet than
> it was generating, which is fixed in a separate patch).
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
> 
> Change from V1: keep default filter of "clean-traffic" rather than no filter.
> 
>  lib/Sys/Virt/TCK.pm                     | 9 ++++++---
>  scripts/nwfilter/230-no-mac-broadcast.t | 3 ++-
>  2 files changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|