[libvirt] [PATCH] qemu: Error out on invalid pci-root controller model name

Andrea Bolognani abologna at redhat.com
Fri Feb 9 16:15:23 UTC 2018


This is a hard error, and should be handled as such.
Introduced in 24614760228b.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 src/qemu/qemu_domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 16833474a..178ec24ae 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4446,7 +4446,7 @@ qemuDomainDeviceDefValidateControllerPCI(const virDomainControllerDef *controlle
                            _("PCI controller model name '%s' is not valid "
                              "for a pci-root"),
                            modelName);
-            return 0;
+            return -1;
         }
 
         if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE)) {
-- 
2.14.3




More information about the libvir-list mailing list