[libvirt] [PATCH 02/11] qemu: Use switch in qemuDomainDefValidateFeatures()

John Ferlan jferlan at redhat.com
Mon Feb 12 17:55:00 UTC 2018



On 02/06/2018 11:42 AM, Andrea Bolognani wrote:
> The compiler can make sure we are handling all features.
> 
> While reworking the logic, also change error messages to a more
> consistent style.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  src/libvirt_private.syms |  2 ++
>  src/qemu/qemu_domain.c   | 57 ++++++++++++++++++++++++++++++++++++------------
>  2 files changed, 45 insertions(+), 14 deletions(-)
> 
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 0bce0bbfb..17c3b71e0 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -345,6 +345,8 @@ virDomainDiskSetDriver;
>  virDomainDiskSetFormat;
>  virDomainDiskSetSource;
>  virDomainDiskSetType;

You'll have a merge conflict right about here...

Reviewed-by: John Ferlan <jferlan at redhat.com>

John




More information about the libvir-list mailing list