[libvirt] [PATCH v2 00/15] qemu: Validate PCI controller options

Andrea Bolognani abologna at redhat.com
Fri Feb 16 16:27:57 UTC 2018


Changes from [v1]:

  * error out instead of silently accept invalid options;
  * shave quite a lot of yaks.


[v1] https://www.redhat.com/archives/libvir-list/2018-February/msg00244.html

Andrea Bolognani (15):
  tests: Add some tests for PCI controller options
  qemu: Move 'done' label in qemuBuildControllerDevStr()
  qemu: Move skip for implicit PHB of pSeries guests
  qemu: Restrict scope in qemuBuildControllerDevStr()
  qemu: Simplify modelName stringification
  qemu: Defer capability check to command line generation time
  qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()
  qemu: Validate PCI controllers (index)
  qemu: Validate PCI controllers (modelName)
  qemu: Validate PCI controllers (targetIndex)
  qemu: Validate PCI controllers (pcihole64)
  qemu: Validate PCI controllers (busNr)
  qemu: Validate PCI controllers (numaNode)
  qemu: Validate PCI controllers (chassisNr)
  qemu: Validate PCI controllers (chassis and port)

 src/qemu/qemu_command.c                            |  80 +++-
 src/qemu/qemu_domain.c                             | 425 +++++++++++++--------
 .../i440fx-controllers-pciopts.xml                 |  36 ++
 tests/qemuxml2argvdata/pcie-expander-bus.xml       |   3 -
 .../pseries-controllers-pciopts.xml                |  35 ++
 tests/qemuxml2argvdata/q35-controllers-pciopts.xml |  60 +++
 tests/qemuxml2argvtest.c                           |   4 +
 tests/qemuxml2xmloutdata/pcie-expander-bus.xml     |   4 +-
 8 files changed, 475 insertions(+), 172 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/i440fx-controllers-pciopts.xml
 create mode 100644 tests/qemuxml2argvdata/pseries-controllers-pciopts.xml
 create mode 100644 tests/qemuxml2argvdata/q35-controllers-pciopts.xml

-- 
2.14.3




More information about the libvir-list mailing list