[libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

Peter Krempa pkrempa at redhat.com
Mon Feb 19 06:28:30 UTC 2018


On Fri, Feb 16, 2018 at 17:28:04 +0100, Andrea Bolognani wrote:
> We will rewrite pretty much every single line of this function
> over the course of the next several commits, and starting from
> a clean slate rather than replacing it bit by bit makes the
> resulting diffs unmeasurably easier to read and understand,
> and you need fewer of them to boot. Trust me, I tried the other
> approach first :)

Will this remove any checks during the series? If yes, then you probably
should at first rename this function and add a almost-empty wrapper then
add new code to the wrapper and delete the renamed function at the end.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180219/c33e7f51/attachment-0001.sig>


More information about the libvir-list mailing list