[libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

Andrea Bolognani abologna at redhat.com
Mon Feb 19 11:43:35 UTC 2018


On Mon, 2018-02-19 at 10:40 +0100, Peter Krempa wrote:
> > Renaming the function won't work because then the compiler will
> > complain about it being unused. Unless you meant something like
> > 
> >   /* Delete once done */
> >   ValidateControllerPCIOld() {
> >     /* Existing checks here */
> >   }
> > 
> >   ValidateControllerPCI() {
> >     /* New checks here */
> > 
> >     /* Delete once done */
> >     ValidateControllerPCIOld();
> >   }
> > 
> > which could actually do the trick.
> 
> I meant this flow obviously, so that the checks are kept until
> fixed/reimplemented.

It was not obvious to me when reading the first message :)

But I agree it's a better way to handle the situation, so I will
do it this way in v3.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list