[libvirt] [PATCH] nwfilter: assure that virNWFilterSnoop(Eth|Dhcp)Hdr objects don't change size

Daniel P. Berrangé berrange at redhat.com
Tue Feb 20 09:13:54 UTC 2018


On Mon, Feb 19, 2018 at 02:30:19PM -0500, Laine Stump wrote:
> These two objects are used to access fields in actual ethernet packets
> captures with libpcap, so it's essential that they don't change size
> for any reason. This patch uses gnulib's verify() macro to make sure
> their sizes don't change.
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
> 
> danpb suggested doing this in his response to my patch fixing virMacAddr:
> 
>   https://www.redhat.com/archives/libvir-list/2018-February/msg00850.html
> 
> I decided to make it a separate patch from the virMacAddr fix.
> 
>  src/nwfilter/nwfilter_dhcpsnoop.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list