[libvirt] [PATCH v3 12/12] qemu: Remove old qemuDomainDeviceDefValidateControllerPCI()

Andrea Bolognani abologna at redhat.com
Wed Feb 21 14:15:01 UTC 2018


We've implemented all existing checks, and more, in the new
function, so we can finally drop the old one.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
Based on the reviewer's preference, this patch can be pushed on
its own or squashed into the previous one.

 src/qemu/qemu_domain.c | 21 +--------------------
 1 file changed, 1 insertion(+), 20 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 3bd80e7886..89bf166aae 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4246,25 +4246,6 @@ qemuDomainDeviceDefValidateControllerSCSI(const virDomainControllerDef *controll
 }
 
 
-static int
-qemuDomainDeviceDefValidateControllerPCIOld(const virDomainControllerDef *controller,
-                                            const virDomainDef *def,
-                                            virQEMUCapsPtr qemuCaps ATTRIBUTE_UNUSED)
-{
-    /* skip pcie-root */
-    if (controller->model == VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT)
-        return 0;
-
-    /* Skip pci-root, except for pSeries guests (which actually
-     * support more than one PCI Host Bridge per guest) */
-    if (!qemuDomainIsPSeries(def) &&
-        controller->model == VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT)
-        return 0;
-
-    return 0;
-}
-
-
 /**
  * virDomainControllerPCIModelNameToQEMUCaps:
  * @modelName: model name
@@ -4825,7 +4806,7 @@ qemuDomainDeviceDefValidateControllerPCI(const virDomainControllerDef *cont,
     }
 
  done:
-    return qemuDomainDeviceDefValidateControllerPCIOld(cont, def, qemuCaps);
+    return 0;
 }
 
 
-- 
2.14.3




More information about the libvir-list mailing list