[libvirt] [PATCH 1/3] lxc: Drop useless check in live device update

Jiri Denemark jdenemar at redhat.com
Thu Feb 22 14:21:53 UTC 2018


Checking the new device definition makes little sense when lxc driver
does not support live device update at all.

Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
---
 src/lxc/lxc_driver.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 3d5b2254f2..4c6f09a435 100644
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -4939,9 +4939,6 @@ static int lxcDomainUpdateDeviceFlags(virDomainPtr dom,
     }
 
     if (flags & VIR_DOMAIN_AFFECT_LIVE) {
-        if (virDomainDefCompatibleDevice(vm->def, dev_copy) < 0)
-            goto endjob;
-
         virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                        _("Unable to modify live devices"));
 
-- 
2.16.2




More information about the libvir-list mailing list