[libvirt] [PATCH 0/3] qemu: Fix updating device with boot order

Michal Privoznik mprivozn at redhat.com
Fri Feb 23 09:16:27 UTC 2018


On 02/22/2018 03:21 PM, Jiri Denemark wrote:
> Commit v3.7.0-14-gc57f3fd2f8 prevented adding a <boot order='x'/>
> element to an inactive domain with global <boot dev='...'/> element.
> However, as a result of that change updating any device with boot order
> would fail with 'boot order X is already used by another device', where
> "another device" is in fact the device which is being updated.
> 
> To fix this we have to ignore the device which we're about to update
> when checking for boot order conflicts.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1546971
> 
> Jiri Denemark (3):
>   lxc: Drop useless check in live device update
>   Pass oldDev to virDomainDefCompatibleDevice on device update
>   qemu: Fix updating device with boot order
> 
>  src/conf/domain_conf.c | 30 ++++++++++++++++++++++-------
>  src/conf/domain_conf.h |  3 ++-
>  src/lxc/lxc_driver.c   | 18 +++++++++---------
>  src/qemu/qemu_driver.c | 51 ++++++++++++++++++++++++++++++++++++++++----------
>  4 files changed, 75 insertions(+), 27 deletions(-)
> 

ACK

Michal




More information about the libvir-list mailing list